From 0ae8409f4fa7feeb38552bc793be1cf7ace36312 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Thu, 8 Sep 2022 14:59:25 -0700 Subject: [PATCH] [Fix] `nvm install-latest-npm`: ensure npm 9 does not install on unsupported nodes --- nvm.sh | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/nvm.sh b/nvm.sh index 0725427..19dee96 100644 --- a/nvm.sh +++ b/nvm.sh @@ -283,6 +283,11 @@ nvm_install_latest_npm() { if [ $NVM_IS_13_OR_ABOVE -eq 1 ] && nvm_version_greater_than_or_equal_to "${NODE_VERSION}" 14.15.0; then NVM_IS_14_LTS_OR_ABOVE=1 fi + local NVM_IS_14_17_OR_ABOVE + NVM_IS_14_17_OR_ABOVE=0 + if [ $NVM_IS_14_LTS_OR_ABOVE -eq 1 ] && nvm_version_greater_than_or_equal_to "${NODE_VERSION}" 14.17.0; then + NVM_IS_14_17_OR_ABOVE=1 + fi local NVM_IS_15_OR_ABOVE NVM_IS_15_OR_ABOVE=0 if [ $NVM_IS_14_LTS_OR_ABOVE -eq 1 ] && nvm_version_greater_than_or_equal_to "${NODE_VERSION}" 15.0.0; then @@ -293,6 +298,21 @@ nvm_install_latest_npm() { if [ $NVM_IS_15_OR_ABOVE -eq 1 ] && nvm_version_greater_than_or_equal_to "${NODE_VERSION}" 16.0.0; then NVM_IS_16_OR_ABOVE=1 fi + local NVM_IS_16_LTS_OR_ABOVE + NVM_IS_16_LTS_OR_ABOVE=0 + if [ $NVM_IS_16_OR_ABOVE -eq 1 ] && nvm_version_greater_than_or_equal_to "${NODE_VERSION}" 16.13.0; then + NVM_IS_16_LTS_OR_ABOVE=1 + fi + local NVM_IS_17_OR_ABOVE + NVM_IS_17_OR_ABOVE=0 + if [ $NVM_IS_16_LTS_OR_ABOVE -eq 1 ] && nvm_version_greater_than_or_equal_to "${NODE_VERSION}" 17.0.0; then + NVM_IS_17_OR_ABOVE=1 + fi + local NVM_IS_18_OR_ABOVE + NVM_IS_18_OR_ABOVE=0 + if [ $NVM_IS_17_OR_ABOVE -eq 1 ] && nvm_version_greater_than_or_equal_to "${NODE_VERSION}" 18.0.0; then + NVM_IS_18_OR_ABOVE=1 + fi if [ $NVM_IS_4_4_OR_BELOW -eq 1 ] || { [ $NVM_IS_5_OR_ABOVE -eq 1 ] && nvm_version_greater 5.10.0 "${NODE_VERSION}"; \ @@ -321,6 +341,14 @@ nvm_install_latest_npm() { ; then nvm_echo '* `npm` `v7.x` is the last version that works on `node` `v13`, `v15`, below `v12.13`, or `v14.0` - `v14.15`' $NVM_NPM_CMD install -g npm@7 + elif \ + { [ $NVM_IS_12_LTS_OR_ABOVE -eq 1 ] && [ $NVM_IS_13_OR_ABOVE -eq 0 ]; } \ + || { [ $NVM_IS_14_LTS_OR_ABOVE -eq 1 ] && [ $NVM_IS_14_17_OR_ABOVE -eq 0 ]; } \ + || { [ $NVM_IS_16_OR_ABOVE -eq 1 ] && [ $NVM_IS_16_LTS_OR_ABOVE -eq 0 ]; } \ + || { [ $NVM_IS_17_OR_ABOVE -eq 1 ] && [ $NVM_IS_18_OR_ABOVE -eq 0 ]; } \ + ; then + nvm_echo '* `npm` `v8.x` is the last version that works on `node` `v12`, `v14.13` - `v14.16`, or `v16.0` - `v16.12`' + $NVM_NPM_CMD install -g npm@8 else nvm_echo '* Installing latest `npm`; if this does not work on your node version, please report a bug!' $NVM_NPM_CMD install -g npm