[Tests] github actions removed homebrew and broke shellcheck

See https://github.com/actions/runner-images/issues/6283

.github/workflows/shellcheck.yml

@@ -34,11 +34,14 @@ jobs:
             github.com:443
             pkg-containers.githubusercontent.com:443
       - uses: actions/checkout@v2
-      - name: Install shellcheck
+      - name: Set up Homebrew
+        uses: Homebrew/actions/setup-homebrew@master
+      - name: Install latest shellcheck
         run: brew install shellcheck
         env:
           HOMEBREW_NO_ANALYTICS: 1
-      - run: "shellcheck --version"
+      - run: which shellcheck
+      - run: shellcheck --version
       - name: Run shellcheck on ${{ matrix.file }}
         run: shellcheck -s ${{ matrix.shell }} ${{ matrix.file }}
 

install.sh

@@ -362,6 +362,8 @@ nvm_do_install() {
       exit 1
     fi
   fi
+  # Disable the optional which check, https://www.shellcheck.net/wiki/SC2230
+  # shellcheck disable=SC2230
   if nvm_has xcode-select && [ "$(xcode-select -p >/dev/null 2>/dev/null ; echo $?)" = '2' ] && [ "$(which git)" = '/usr/bin/git' ] && [ "$(which curl)" = '/usr/bin/curl' ]; then
     nvm_echo >&2 'You may be on a Mac, and need to install the Xcode Command Line Developer Tools.'
     # shellcheck disable=SC2016