From 896aa7c43693c8ac94c5a79ddd56ead3384c776f Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Mon, 19 May 2014 22:03:40 -0700 Subject: [PATCH] Updating CONTRIBUTING guidelines Fixes #425 --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f1f07a9..5948d7d 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -5,7 +5,7 @@ We love pull requests, they're our favorite. However, before submitting, please review the following: - Please include tests. Changes with tests will be merged very quickly. - - Please manually confirm that your changes, and all tests, pass in `bash`, `sh`, and `zsh`. We hope to soon automatically run all these tests, but in the meantime, we have to rely on each contributor doing so. + - Please manually confirm that your changes work in `bash`, `sh`/`dash`, `ksh`, and `zsh`. Fast tests do run in these shells, but it's nice to manually verify also. - Please maintain consistent whitespace - 2-space indentation, trailing newlines in all files, etc. - Any time you make a change to your PR, please rebase freshly on top of master. Nobody likes merge commits.