273345896
/
nvm
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Fix] Don't override Mac M1 architecture for node ^14.17 

Fixes #2743

Co-authored-by: Josh Kelley <joshkel@gmail.com>
Co-authored-by: Raz Luvaton <16746759+rluvaton@users.noreply.github.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Josh Kelley 2022-03-30 10:53:01 -04:00 committed by Jordan Harband
parent 28b3b0e324
commit c6269e0ac2
No known key found for this signature in database
GPG Key ID: 9F6A681E35EF8B56
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -156,7 +156,7 @@ If the above doesn't fix the problem, you may try the following:
- For more information about this issue and possible workarounds, please [refer here](https://github.com/nvm-sh/nvm/issues/576) - For more information about this issue and possible workarounds, please [refer here](https://github.com/nvm-sh/nvm/issues/576)
**Note** For Macs with the M1 chip, node started providing **arm64** arch darwin packages since v16.0.0. For earlier versions, there were only **darwin_x64** packages available but no **darwin_arm64**. If you are facing issues installing node using `nvm`, you may want to update to v16 or later. **Note** For Macs with the M1 chip, node started offering **arm64** arch darwin packages since v16.0.0 and experimental **arm64** support when compiling from source since v14.17.0. If you are facing issues installing node using `nvm`, you may want to update to one of those versions or later.
#### Ansible #### Ansible

9
nvm.sh
View File

@ -2110,9 +2110,12 @@ nvm_get_download_slug() {
fi fi
fi fi
# If node version in below 16.0.0 then there is no arm64 packages available in node repositories, so we have to install "x64" arch packages # If running MAC M1 :: Node v14.17.0 was the first version to offer official experimental support:
# If running MAC M1 :: arm64 arch and Darwin OS then use "x64" Architecture because node doesn't provide darwin_arm64 package below v16.0.0 # https://github.com/nodejs/node/issues/40126 (although binary distributions aren't available until v16)
if nvm_version_greater '16.0.0' "${VERSION}"; then if \
nvm_version_greater '14.17.0' "${VERSION}" \
|| (nvm_version_greater_than_or_equal_to "${VERSION}" '15.0.0' && nvm_version_greater '16.0.0' "${VERSION}") \
; then
if [ "_${NVM_OS}" = '_darwin' ] && [ "${NVM_ARCH}" = 'arm64' ]; then if [ "_${NVM_OS}" = '_darwin' ] && [ "${NVM_ARCH}" = 'arm64' ]; then
NVM_ARCH=x64 NVM_ARCH=x64
fi fi