From c7ac69bfbb677b17f0f50f885c072da3004530c9 Mon Sep 17 00:00:00 2001 From: Ahmad Magdy Date: Thu, 30 Nov 2017 14:47:42 +0100 Subject: [PATCH] Fix nvm_install_node function in install.sh script to not override the actual NODE_VERSION value --- install.sh | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/install.sh b/install.sh index e0d793e..120c98a 100755 --- a/install.sh +++ b/install.sh @@ -140,22 +140,22 @@ install_nvm_from_git() { # Automatically install Node.js # nvm_install_node() { - local NODE_VERSION - NODE_VERSION="$(nvm_node_version)" + local NODE_VERSION_LOCAL + NODE_VERSION_LOCAL="$(nvm_node_version)" - if [ -z "$NODE_VERSION" ]; then + if [ -z "$NODE_VERSION_LOCAL" ]; then return 0 fi - echo "=> Installing Node.js version $NODE_VERSION" - nvm install "$NODE_VERSION" + echo "=> Installing Node.js version $NODE_VERSION_LOCAL" + nvm install "$NODE_VERSION_LOCAL" local CURRENT_NVM_NODE CURRENT_NVM_NODE="$(nvm_version current)" - if [ "$(nvm_version "$NODE_VERSION")" == "$CURRENT_NVM_NODE" ]; then - echo "=> Node.js version $NODE_VERSION has been successfully installed" + if [ "$(nvm_version "$NODE_VERSION_LOCAL")" == "$CURRENT_NVM_NODE" ]; then + echo "=> Node.js version $NODE_VERSION_LOCAL has been successfully installed" else - echo >&2 "Failed to install Node.js $NODE_VERSION" + echo >&2 "Failed to install Node.js $NODE_VERSION_LOCAL" fi }