[Robustness] avoid IFS shenanigans: quote arg count/return codes

Jordan Harband 2021-08-24 09:34:01 -07:00
parent e98e9d9e4b
commit e0df5e92e3
No known key found for this signature in database
GPG Key ID: 9F6A681E35EF8B56
1 changed files with 5 additions and 5 deletions

10
nvm.sh
View File

@ -2640,7 +2640,7 @@ nvm_cache_dir() {
} }
nvm() { nvm() {
if [ $# -lt 1 ]; then if [ "$#" -lt 1 ]; then
nvm --help nvm --help
return return
fi fi
@ -2652,12 +2652,12 @@ nvm() {
set +e set +e
local EXIT_CODE local EXIT_CODE
IFS="${DEFAULT_IFS}" nvm "$@" IFS="${DEFAULT_IFS}" nvm "$@"
EXIT_CODE=$? EXIT_CODE="$?"
set -e set -e
return $EXIT_CODE return "$EXIT_CODE"
elif [ "${IFS}" != "${DEFAULT_IFS}" ]; then elif [ "${IFS}" != "${DEFAULT_IFS}" ]; then
IFS="${DEFAULT_IFS}" nvm "$@" IFS="${DEFAULT_IFS}" nvm "$@"
return $? return "$?"
fi fi
local i local i
@ -4227,7 +4227,7 @@ nvm_auto() {
nvm_process_parameters() { nvm_process_parameters() {
local NVM_AUTO_MODE local NVM_AUTO_MODE
NVM_AUTO_MODE='use' NVM_AUTO_MODE='use'
while [ $# -ne 0 ]; do while [ "$#" -ne 0 ]; do
case "$1" in case "$1" in
--install) NVM_AUTO_MODE='install' ;; --install) NVM_AUTO_MODE='install' ;;
--no-use) NVM_AUTO_MODE='none' ;; --no-use) NVM_AUTO_MODE='none' ;;