From ffcb5213e20df51d50725d17b6b5117022bd308a Mon Sep 17 00:00:00 2001 From: William Baker Date: Fri, 10 Mar 2023 00:53:29 -0500 Subject: [PATCH] [Perf] Improve performance of listing aliases Fixes #3054 --- nvm.sh | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/nvm.sh b/nvm.sh index 6ea962a..1b34df3 100644 --- a/nvm.sh +++ b/nvm.sh @@ -1068,7 +1068,7 @@ nvm_list_aliases() { ( local ALIAS_NAME - for ALIAS_NAME in "$(nvm_node_prefix)" "stable" "unstable"; do + for ALIAS_NAME in "$(nvm_node_prefix)" "stable" "unstable" "$(nvm_iojs_prefix)"; do { # shellcheck disable=SC2030,SC2031 # (https://github.com/koalaman/shellcheck/issues/2217) if [ ! -f "${NVM_ALIAS_DIR}/${ALIAS_NAME}" ] && { [ -z "${ALIAS}" ] || [ "${ALIAS_NAME}" = "${ALIAS}" ]; }; then @@ -1077,11 +1077,6 @@ nvm_list_aliases() { } & done wait - ALIAS_NAME="$(nvm_iojs_prefix)" - # shellcheck disable=SC2030,SC2031 # (https://github.com/koalaman/shellcheck/issues/2217) - if [ ! -f "${NVM_ALIAS_DIR}/${ALIAS_NAME}" ] && { [ -z "${ALIAS}" ] || [ "${ALIAS_NAME}" = "${ALIAS}" ]; }; then - NVM_NO_COLORS="${NVM_NO_COLORS-}" NVM_CURRENT="${NVM_CURRENT}" nvm_print_default_alias "${ALIAS_NAME}" - fi ) | sort ( @@ -1376,9 +1371,10 @@ nvm_ls() { if [ "${NVM_ADD_SYSTEM-}" = true ]; then if [ -z "${PATTERN}" ] || [ "${PATTERN}" = 'v' ]; then - VERSIONS="${VERSIONS}$(command printf '\n%s' 'system')" + VERSIONS="${VERSIONS} +system" elif [ "${PATTERN}" = 'system' ]; then - VERSIONS="$(command printf '%s' 'system')" + VERSIONS="system" fi fi