Commit Graph

1898 Commits (1c00753fd9c3ae5e0bb3f4992c5e283ef5bf5085)

Author SHA1 Message Date
Peter Dave Hello 20a40dd8c2
[Docs] Update CONTRIBUTING.md 2017-03-23 04:46:49 +08:00
Peter Dave Hello 237c3a78e2 [Tests] Add retry on urchin setup which has no built in retry feature
Unlike other built in functions like git fetch or apt-get dependencies,
manual installations won't have retry by default, enabling retry could
help reduce the impact of network issues and furthur prevent getting
build error like Job #1956.21:
- https://travis-ci.org/creationix/nvm/jobs/212640007

Ref:
- https://docs.travis-ci.com/user/common-build-problems/
2017-03-22 20:42:33 +08:00
Peter Dave Hello fa3631fee3
[Refactor] Add `nvm_has_non_aliased` 2017-03-20 16:57:26 +08:00
Peter Dave Hello 316c9f34c6
[Performance] Use awk's comparison to save a pipe to grep 2017-03-20 04:50:32 +08:00
Peter Dave Hello 6cb12b0f99
[Performance] Improve awk usage 2017-03-21 04:23:53 +08:00
Peter Dave Hello 6ed73b0696 [Refactor] Improve sed usage for performance 2017-03-20 17:53:44 -07:00
Shirsh Zibbu dcd008ff61
[Refactor] remove unnecessary quotes 2017-03-07 05:46:45 +05:30
Peter Dave Hello 039afb9470
[Docs] Update Installation section
1. If we are not going to install nodejs or io.js from source, we may
not need to have c++ compiler or libssl-dev package
2. the `build-essential` and `libssl-dev` packages should work on all
the Debian and Ubuntu based GNU/Linux distros
3. Remove useless blank lines
2017-03-16 04:22:29 +08:00
Peter Dave Hello b879628394 [Fix] declare MANPATH if and only if it's not set
By manpath's man page in Ubuntu 16.04:

> If $MANPATH is set, manpath will simply display its contents and issue
> a warning.

By fa22d712ff for #1413, `nvm` now will
declare the "MANPATH" variable, no matter if it's set or not, so in the
situation that $MANPATH is set, you'll get the warning:

> manpath: warning: $MANPATH set, ignoring /etc/manpath.config
2017-03-19 02:19:14 +08:00
Jordan Harband 9b2629384f
[Fix] `nvm install -s`: ensure additional params lack a trailing space.
Note: I believe this does not fix the underlying issue in zsh, which is
that it does not split up `$ADDITIONAL_PARAMETERS` and instead passes
the contents as one single argument.
2017-03-17 23:20:17 -07:00
Peter Dave Hello 50ae1e5199
[Fix] Install failed should return correct exit status, fix #1347 2016-12-10 00:20:04 +08:00
Matthew McEachen 1e6b5ce039
[Fix] stop setting mirror env vars unnecessarily
Fixes #1429
2017-03-16 23:54:55 -07:00
Peter Dave Hello 952d0067b3 [Fix] bash_completion should make sure nvm loaded 2017-03-15 14:34:28 +08:00
Peter Dave Hello 911ff87601 [Fix] bash_completion source prompt, remove && 2017-03-15 14:34:28 +08:00
Peter Dave Hello 9593616b8c [Fix] NVM_PROFILE bash/zsh detection in installation 2017-03-15 14:34:28 +08:00
Peter Dave Hello d8538dad84 [Refactor] nvm.sh minor refactor 2017-03-14 17:45:54 +08:00
Alex Ryan 257f16fb13
[Docs] fi README typo 2017-03-13 03:16:08 -07:00
Peter Dave Hello 182a18d911
[Fix] Github should be GitHub 2017-03-09 23:02:08 +08:00
Peter Dave Hello 8e6201b5b1
[Tests] Update test mocks 2017-03-10 18:02:47 +08:00
Dominyk Tiller b676bf7d0e
[Fix] checksums: remove libressl command support
This was an "oops" on my part when I was testing changes for my work
that was later adapted & merged in f1bca106a8.
LibreSSL is never installed as a `libressl` as it is intended to be a
replacement for `openssl` as much as possible, and consequently the
executable is called `openssl`.
2017-03-08 12:54:37 +00:00
Jordan Harband fa22d712ff
[Fix] ensure this variable is not unbound.
Fixes #1413.
2017-03-06 09:35:58 -08:00
Jordan Harband 286090b607 Merge pull request #1408 from PeterDaveHello/doctoc
[Docs] [Tests] Introduce doctoc for "Table of Contents" autogeneration
2017-03-01 00:57:05 -08:00
Peter Dave Hello 1689b174b3 [Test] Add doctoc up-to-date test in TravisCI 2017-02-28 08:45:48 +08:00
Peter Dave Hello f8aaa32d17 README minor adjustment, generate "Table of Content" via doctoc 2017-02-27 18:33:41 +08:00
Peter Dave Hello 3dc5777b66 Add doctoc devDependency and npm script
Will use it to generate "Table of Contents"
2017-02-27 01:35:36 +08:00
Jordan Harband 6669e91bd8
v0.33.1 2017-02-20 17:59:20 -08:00
John-David Dalton 7c271729ef Enable working without tput. 2017-02-19 23:01:47 -08:00
Jordan Harband b54e147442
[Fix] `nvm unload`: run `nvm deactivate` before unsetting everything.
Fixes #1399.
2017-02-18 00:50:33 -08:00
Jordan Harband e7e4a9b3d6
[Fix] unset `NVM_RC_VERSION` env var immediately after it’s no longer needed.
Relates to #1399.
2017-02-18 00:48:41 -08:00
Jordan Harband 49e446dac1
[debug] include mirrors in `nvm debug` output. 2017-02-14 09:06:23 -08:00
Robin Schneider 1b8b7b31ed
Add CII best practices badge
Thanks to @ljharb for applying for it!

Related to: #1395
2017-02-12 11:00:10 +01:00
Jordan Harband 6fc0241c21
[Fix] `install.sh`: only un-interpolate $HOME for the profile source string.
Fixes #1384.
2017-02-12 00:32:49 -08:00
Jordan Harband affcc5087c [Fix] `set -e`: `nvm install lts/something`: call `nvm_ensure_default_set` with the proper value.
Fixes #1394.
2017-02-11 23:19:29 -08:00
Ryan Wheale 1b2305232f
[install script] Use `$HOME` variable in `NVM_DIR` 2017-01-12 10:55:56 -07:00
butlerx f1a5f2a15f
[Docs] [Fix] zsh autochange: only `nvm install` if we can’t `nvm use` 2016-12-19 12:00:47 +00:00
Jordan Harband 40e40975eb
v0.33.0 2016-12-29 21:22:13 -10:00
Jordan Harband ae8eb80d0b `make release` should pop up the EDITOR for the annotated tag. 2016-12-29 21:22:08 -10:00
Jordan Harband 186509be24 [github] modify the issue template 2016-12-28 09:04:12 -10:00
Jordan Harband 853afbf595
Revert "Revert "[Fix] `set -u`: ensure that potentially unbound variables aren’t called unchecked.""
This reverts commit a8c465018e.

Fixes #1363.
2016-12-26 21:57:55 -08:00
Jordan Harband a8c465018e
Revert "[Fix] `set -u`: ensure that potentially unbound variables aren’t called unchecked."
This reverts commit 60239e39cd.
2016-12-25 12:18:56 -08:00
Jordan Harband 1cac5194b9 [github] Flesh out issue template a bit. 2016-12-25 12:07:08 -08:00
Peter Dave Hello 71b49f1744
Add GitHub issue template 2016-12-26 02:46:49 +08:00
Jordan Harband 60239e39cd
[Fix] `set -u`: ensure that potentially unbound variables aren’t called unchecked.
Fixes #1363.
2016-12-25 11:31:37 -08:00
Jordan Harband 0f6997d90a [Tests] remove the unused and broken `$NVM_PATH`. 2016-12-16 11:23:23 -08:00
Jordan Harband fcd6331f09 [Fix] remove the unused and broken `$NVM_PATH`.
Added in 359a83e. Fixes #1353.
2016-12-16 10:57:22 -08:00
Peter Dave Hello 2af47b0034 [Docs] Remove mixed addtional indent in the Bash completion codeblock 2016-12-03 21:33:54 +08:00
Peter Dave Hello 7c0dc2be68 [Docs] Make the indent in readme consistenly use soft tabs 2016-12-03 21:32:41 +08:00
Peter Dave Hello d5340539d9 [Docs] Link version badge to the release page 2016-12-02 19:33:48 +08:00
Peter Dave Hello 45771499ee
[Fix] nvm should respect CC/CXX env var
- Also set CC for Freebsd, not only CXX

 - Also set CC=cc, CXX=c++ on Mac OS by default as upstream

Reference:
1bd871655a/configure (L16-L17)
2016-11-29 15:30:01 +08:00
Peter Dave Hello 84575cf353
[Refactor] Use "case" instead of multi "if" 2016-11-28 03:39:48 +08:00