Commit Graph

996 Commits (2cfced740afdc3223d05f34dc1a1d80b1f1621f2)

Author SHA1 Message Date
Jordan Harband a82edf40ba
[Robustness] avoid a clobbered `ls`
Fixes #2824
2022-06-02 12:25:55 -07:00
deepakchethan 9e884b8d7b
[Fix] `nvm install`: show proper version in `.nvmrc` install instructions 2022-03-22 18:58:18 +05:30
Jordan Harband c2f740ab38
[patch] HTTP -> HTTPS 2022-01-18 12:49:57 -08:00
Luke Arms 1875fe8b40
[Fix] avoid OpenBSD `nvm install` error when /sbin/init doesn't exist
`nvm install` fails with "Binary download failed, trying source" when
- running on Bash;
- errtrace (`set -E`) is enabled;
- an ERR trap uses `exit` to return a non-zero status; and
- /sbin/init doesn't exist.

Resolved by moving `ls -dl /sbin/init` to the following `if` statement.
In this context, returning non-zero isn't an error and the ERR trap
isn't executed.
2021-12-26 15:31:53 +11:00
Luke Arms 81f0f3ec19
[Fix] `set -E`: Add test for `node install` on Bash with an ERR trap and `set -E` 2021-12-27 16:02:25 +11:00
lsfxz fb4538b360
[Fix] add missing `local` (handle nonexisting /sbin/init a bit more cleanly) 2021-11-17 16:59:53 +01:00
Bob Bregant II 79ad72d116
[Fix] Update `nvm_extract_tarball` to support OpenBSD
Fixes #2660.
2021-12-19 02:58:18 +00:00
Bob Bregant II ccd442d833
[Refactor] add `nvm_extract_tarball` to consolidate extraction logic 2021-12-19 02:58:18 +00:00
Jordan Harband 9600617c52
v0.39.1 2021-12-17 14:55:52 -08:00
Jordan Harband aa57406ede
[Fix] ensure `unload` removes `nvm_normalize_lts` 2021-12-17 13:55:14 -08:00
Jordan Harband c4c7690dec
[Fix] `ls-remote`/`install`: support `lts/-X` patterns in installs
Fixes #2692
2021-12-16 23:01:05 -08:00
Jordan Harband aed1d732d7
[Fix] `ls-remote`/`install`: properly handle `lts/x` patterns 2021-12-16 22:58:06 -08:00
Jordan Harband 0b4cd8df6c
[Refactor] create `nvm_normalize_lts` helper 2021-12-16 22:55:02 -08:00
Jordan Harband 430860a8be
[Fix] `nvm alias`/`nvm_list_aliases`: support `lts/` aliases
See #2692
2021-12-16 15:54:38 -08:00
Ankit Kumar 328dd5004e
[Fix] `nvm_get_download_slug`: better architecture selection for M1 Macs
If the node version is below 16.0.0 then nvm will select x86_64 architecture, else arm64 architecture.
2021-11-21 15:59:39 +05:30
Jordan Harband 2f40eeef2e
[shellcheck] apply v0.8.0 updates 2021-11-19 08:53:43 -08:00
Wu Jiang a284af9228
[New] Add OpenBSD support 2016-04-14 20:57:10 -04:00
Jordan Harband 5b3d188b83
v0.39.0 2021-10-07 10:11:35 -07:00
Matteo De Wint 93e0070a44
[Fix] `nvm_die_on_prefix`: filter prefixed env vars on name only, ignoring values 2020-11-28 15:16:35 +01:00
Jordan Harband ebbd30eb7f
[Fix] `nvm install-latest-npm`: ensure npm 8 does not install on unsupported nodes 2021-10-05 15:13:45 -07:00
Kaito Udagawa 53f9ba8336
[Refactor] Use awk for path stripping
This works with paths which contains regex meta characters.
2016-12-23 01:03:41 +09:00
Axel Svensson 11d71ab24b
[Fix] Regression in 2dad045
Fixes #2599
2021-09-24 01:56:47 +02:00
Jordan Harband b6b6e685a3
[Fix] `set -a`: when this option is set, some `sh` shells break
Fixes #2574
2021-09-14 23:26:31 -07:00
Jordan Harband 2dad0455ec
[Fix] `nvm_die_on_prefix`: avoid grepping env functions in bash
ironically, nvm itself has functions that matched this grep.
2021-09-08 23:49:16 -07:00
Jordan Harband f03f69508e
[Fix] `reinstall-packages`: handle global symlink locations properly
This is a regression caused by npm ls -g in npm 7 no longer returning absolute paths.
2021-09-07 10:14:18 -07:00
Kevin Stolp 291c7c4c47
[Fix] `nvm_ls_remote_index_tab`: handle long version lists 2021-09-03 23:40:13 -07:00
Jordan Harband 5b77f7d023
[Fix] `nvm ls`/`nvm alias`/`nvm_list_aliases`: zsh: when no LTS aliases, no error
Fixes #2575.
2021-09-01 10:06:32 -07:00
Jordan Harband e0df5e92e3
[Robustness] avoid IFS shenanigans: quote arg count/return codes 2021-08-24 09:34:01 -07:00
Jordan Harband 7f2ccd51d4
[Fix] `nvm_get_arch`: suppress error output if `/sbin` does not exist
Introduced by #2469
2021-08-05 08:05:54 -07:00
Jordan Harband b5165ecbe4
[shellcheck] update for new warnings in v0.7.2 2021-05-03 14:19:31 -07:00
nmarghetti f2582275f6
[New] maybe support Windows with WSL, MSYS, Cygwin 2021-01-02 00:03:24 +01:00
Botspot 779a34e6a9
[Fix] `nvm_get_arch`: Rasbperry Pi: armv7l with arm64 kernel, get correct arch
Co-authored-by: Botspot <54716352+Botspot@users.noreply.github.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Sladyn Nunes <sladynnunes98@gmail.com>
2021-03-22 14:56:25 -05:00
Jordan Harband 3fea5493a4
v0.38.0 2021-03-29 12:49:10 -07:00
Rodrigo Espinosa de los Monteros 4da7f101a2
[Fix] `nvm_alias`: ensure `lts/-1` returns the one before `lts/*`
Fixes #2461
2021-03-11 16:22:31 -05:00
Lukman 1081ed161b
[New] `install`: add parallel build support for openbsd
Co-authored-by: Lukman <lukmaan.me@gmail.com>
Co-authored-by: Sladyn Nunes <sladynnunes98@gmail.com>
2020-12-26 22:23:35 +05:30
Vesa Vilhonen 52f67b3677
[Fix] `exec`: `--` should stop argument parsing
Co-authored-by: Vesa Vilhonen <vesa@vilhonen.com>
Co-authored-by: Sladyn Nunes <sladynnunes98@gmail.com>
2020-11-20 13:06:28 +02:00
Sladyn Nunes 4fdef427e4
[New] `install`: add `-b` flag to skip building from source
Fixes #2114.
2021-02-16 19:34:23 +05:30
nmarghetti 7f6c0c053a
[Refactor] add `nvm_install_binary_extract` 2021-01-02 00:03:24 +01:00
nmarghetti d396181ffb
[Refactor] add `nvm_get_artifact_compression` 2021-01-02 00:03:24 +01:00
Brandon L. Reiss 3243f7a082
[Fix] Fix potential unbound var error on nvm install
Fixes #2420. When using `nvm install` with an already installed
version, Bash (and potentially other shells) may emit an unbound
variable error when `set -u` is set. The presence of the error depends
on specific shell versions, but appears to happen in MacOS 11.1 (Big
Sur) using a recent Bash version installed via Homebrew (as of this
writing).

The fix accesses `ALIAS` correctly for the case where it is not set by
an `alias` option to `nvm install`.
2021-01-27 13:12:17 -05:00
Hosam Aly 31c5c5c45a
[Fix] avoid parse error with common omz global aliases, in `nvm_print_color_code`
Fixes #2362. Fixes #2372.
2020-11-27 23:17:07 +00:00
Jordan Harband 436cda247e
[Fix] remove `nvm_supports_source_options`
Fixes #2387
2021-01-07 13:00:26 -08:00
Jordan Harband 3c079f16c7
[shellcheck] fix silly shellcheck complaint 2020-12-21 23:47:25 -08:00
Jordan Harband e76b2945c5
[Fix] relax `$PREFIX` checking, to accomodate `npm exec`
Fixes #2379.
2020-12-21 23:03:30 -08:00
Keith Lazuka 86708833c9
[Fix] Use local variable when looping over args
When the `nvm` function is called by a script which itself uses a variable
named `i`, `nvm` clobbers the caller's variable. This happens even if the
caller has declared its variable as local.

See note 1 on https://tldp.org/LDP/abs/html/localvar.html#FTN.AEN18568
2020-12-08 12:28:24 -05:00
Jordan Harband 4b947ec92d
v0.37.2 2020-11-27 21:34:28 -08:00
Jordan Harband 3b57dfec8d
Revert "[Fix] `nvm_die_on_prefix`: only grep lines starting with env var name" (#2347)
This reverts commit 21c0c05130.

Fixes #2360. Fixes #2364. Fixes #2366.
2020-11-27 21:28:12 -08:00
Jordan Harband 661a702cdd
v0.37.1 2020-11-24 21:16:43 -08:00
Dena Burd 6848c16d53
[New] Added `set-colors` command. See details below:
This command allows users to replace default colors with their own custom colors.

 - top-level commands modified: alias, ls, ls-remote
 - helper functions added: nvm_echo_with_colors, nvm_err_with_colors,
nvm_set_colors, nvm_get_colors, nvm_print_color_code
 - functions modified: nvm_print_formatted_alias, nvm_print_versions, nvm_print_alias_path (implicitly), nvm_print_default_alias (implicitly), nvm_list_aliases (implicitly)

We added tests and info on using this command to the README!

Co-authored-by: Dena Burd <29719099+gitburd@users.noreply.github.com>
Co-authored-by: Naomi Quinones <52065567+naomiquinones@users.noreply.github.com>
2020-08-17 14:56:13 -07:00
Matteo De Wint 21c0c05130 [Fix] `nvm_die_on_prefix`: only grep lines starting with env var name 2020-11-16 11:35:26 +01:00