Commit Graph

1405 Commits (68bf93514bdf5d2852ce74819350bed99eb472a6)

Author SHA1 Message Date
Jordan Harband 68bf93514b
[Fix] when originally installed without git, ensure it can be upgraded to use git.
Fixes #1212. Closes #1213.
2016-08-25 00:59:32 -07:00
Jordan Harband 7e18328a88 Merge pull request #1214 from ljharb/shellcheck
[Tests] add `shellcheck`
2016-08-25 01:00:13 -07:00
Jordan Harband 85c5e12710 [Refactor] `install.sh`: use curlies in a few places. 2016-08-24 00:50:08 -07:00
Jordan Harband d0180f7eb2 [shellcheck] build from source to get v0.4.4 2016-08-24 00:30:08 -07:00
Jordan Harband 5ba6e748b7
[Tests] run shellcheck in tests. 2016-08-23 23:07:42 -07:00
Jordan Harband 31c68adbcf
v0.31.6 2016-08-23 14:36:15 -07:00
Aria Stewart 451b67fe78 Revert %s-formatting for SOURCE_STR when writing to shell profile 2016-08-23 17:32:28 -04:00
Jordan Harband d179810b25
v0.31.5 2016-08-23 11:12:21 -07:00
Jordan Harband 1ac7e236b1 [New] Add `lts/foo` support to remote commands.
- `nvm ls-remote`
 - `nvm version-remote`
 - `nvm install`
 - `nvm uninstall`

Document existing support:
 - `nvm use`
 - `nvm exec`
 - `nvm run`

Fixes #1208.
2016-08-23 10:58:00 -07:00
Jordan Harband 681c81ad30 [shellcheck] clean up `install.sh` 2016-08-23 00:45:38 -07:00
Jordan Harband 2228323c0b
[shellcheck] disable intentional violations via comments 2016-08-23 00:31:39 -07:00
Jordan Harband cbeb654692
[shellcheck] properly quote arguments. 2016-08-23 00:31:36 -07:00
Jordan Harband 24a9c089ff
[shellcheck] fix incorrect `A && B || C` usages. 2016-08-23 00:31:25 -07:00
Jordan Harband bc4639c1c9
[Docs] add a road map. 2016-08-21 12:11:43 -07:00
Jordan Harband 54cc3a383e
[Tests] set -ex options on more tests 2016-08-14 09:48:25 -07:00
Jordan Harband d3d768adcd
Add `nvm_get_mirror` 2016-08-10 23:09:54 -07:00
Jordan Harband 9c65197b22
Add `nvm_get_checksum_alg` 2016-08-09 22:24:09 -07:00
Jordan Harband bd3ca47714
[Fix] `nvm unload`: ensure all functions are unset 2016-08-11 10:58:16 -07:00
Jordan Harband ec4efa3ec7
[Refactor] `nvm install`: remove unused `REINSTALL_PACKAGES_FROM` argument to inner installation helpers. 2016-08-11 10:42:32 -07:00
Jordan Harband 08cbcf2254
[Fix] when not using `xz` on merged node versions, use `z` to extract, not `x` 2016-08-10 23:26:29 -07:00
Jordan Harband 4aa6902dbe
[Refactor] `nvm_install_merged_node_binary`: reduce nesting, fix var curlies. 2016-08-10 16:57:03 -07:00
Jordan Harband 0678652bd3 [New] `nvm ls`/`nvm ls-remote`/`nvm alias`: add `--no-colors` 2016-08-09 14:46:19 -07:00
Jordan Harband 206878460c [Refactor] always shift first argument to `nvm` 2016-08-09 13:33:43 -07:00
Jordan Harband 79270a579c
[Refactor] create `nvm_list_aliases` 2016-08-06 22:33:37 -07:00
Jordan Harband b6eb565ea1
[Refactor] `nvm alias`: reorganize so alias listing is done last 2016-08-08 15:50:05 -07:00
Jordan Harband 091c64c7c5
[Refactor] `nvm alias`: add in `--`-based argument support. 2016-08-08 13:37:14 -07:00
Jordan Harband 21b8f556b2
[Refactor] `nvm alias`: use named vars instead of positional args. 2016-08-08 13:21:42 -07:00
Jordan Harband a3bc4d3e62
[Refactor] `nvm alias`: shift out the “alias” 2016-08-08 13:18:53 -07:00
Jordan Harband 150ed490d0 [Refactor] use curlies with variables 2016-08-07 23:31:16 -07:00
Peter Dave Hello 364096a3c3 Add trailing newline char to $SOURCE_STR
Line 302/301 `printf "$SOURCE_STR"` is missing a trailing newline char,
while line 281/282 and 285/286 have their own new line char, so I  just
remove the manually added newline char, and add it to the end of the
variable "$SOURCE_STR", so no more manually newline char needed there.
2016-08-05 15:52:01 +08:00
Peter Dave Hello 88fc93a71b Fix nvm dir path in install script, fix #1189 2016-08-05 15:23:09 +08:00
Jordan Harband f9f140ec13
[Performance] make auto-using faster.
Per https://github.com/creationix/nvm/issues/539#issuecomment-236830764
2016-08-02 00:59:51 -07:00
Luke Childs f653bdc606 Print shell version on Travis 2016-07-31 21:14:30 +01:00
Jordan Harband 31e58d1827
v0.31.4 2016-07-29 16:54:13 -07:00
Julien Gilli a32b914bab Fix nvm on SmartOS setups using 64 bits pkgsrc repository
On SmartOS setups using 64 bits pkgsrc repositories, `nvm_get_arch`
would not handle pkg_info's output properly.

This would result in nvm not being to install any node binary when
running on SmartOS setups using a 64 bits pkgsrc repository.

This change fixes this problem, and fixes the tests suite on similar
setups.
2016-07-29 14:08:31 -07:00
Joe Lencioni f51b1bf8ae Document required git version
git-describe was taught `--abbrev=0` in 1.5.0:

  https://github.com/git/git/blob/master/Documentation/RelNotes/1.5.0.txt

git-describe was taught `--match` in 1.5.5:

  https://github.com/git/git/blob/master/Documentation/RelNotes/1.5.5.txt

I don't see anything else potentially weird in here, so I think it is
safe to proclaim that the minimum git version required to run these
commands is 1.5.5.

Documenting this minimum version required here should help people debug
possible issues and help maintainers of this project understand the
impacts of modifying these commands in the future.
2016-07-28 10:51:00 -07:00
Jordan Harband c874a17479 Merge pull request #1179 from lencioni/improve-upgrade-instructions
[Docs] Improve installation and upgrade instructions
2016-07-28 10:41:31 -07:00
Joe Lencioni 6eef4ce4d2 Use NVM_DIR in installation instructions
As suggested by @ljharb, this might be a little cleaner. I'm not
entirely sure, but in any case, it is consistent with the upgrade
instructions, so that is nice.
2016-07-28 10:36:51 -07:00
Joe Lencioni 54476476ab Use subshells for installation and upgrade instructions
I recently upgraded my copy of nvm and I was disappointed to be dropped
in the .nvm directory at the end of it. I also didn't like having to
copy and paste two separate blocks of code into my terminal, because I
missed the second one the first time around and was left in a slightly
confusing state. So, I decided to make this easier by utilizing
subshells and moving all of the instructions into one code block in this
document. I think this will improve people's experience maintaining this
tool.
2016-07-28 10:36:51 -07:00
Joe Lencioni 87a3a4425d Ensure `git describe` only matches version tags
`git describe` will match the latest tags, regardless of what it looks
like. We can make this a little safer by adding a `--match` flag to
match tags that look like version tags. This allows the maintainers of
this repo to more safely add other types of tags if they so wish,
without causing people to install or upgrade to those versions.
2016-07-28 10:36:51 -07:00
Joe Lencioni 17a3272b8a Ensure `git describe` gives latest tag
I recently ran the upgrade instructions and I ended up with the version
I was already on. This happened because `git describe` describes a
commit using the most recent tag reachable from it. Since I already had
a tag checked out, it was describing the tag I had already checked out.

Thankfully, `git describe` accepts an optional commit-ish, which it will
use instead of what we have currently checked out. Testing this in my
terminal now gives me the latest tag on origin, which is what I am
interested in when updating to the latest version.

  ~/.nvm ❯❯❯ git describe --abbrev=0 --tags
  v0.30.1
  ~/.nvm ❯❯❯ git describe --abbrev=0 --tags origin
  v0.31.3

I also added it to the manual install instructions for consistency and
extra safety.
2016-07-28 10:36:51 -07:00
Luke Childs c08010f610 Fix typo in readme 2016-07-28 17:48:23 +01:00
Jordan Harband 2ee8ec886f Merge pull request #1178 from lukechilds/installation-improvements
Installation improvements
2016-07-28 08:49:28 -07:00
Luke Childs 978f7b4435 Only source nvm, not entire profile 2016-07-27 22:44:51 +01:00
Luke Childs 3417e9d9a3 Add message explaining how to use nvm 2016-07-27 22:39:50 +01:00
Luke Childs eb4de62bc1 Remove incorrect message 2016-07-27 21:43:13 +01:00
Jordan Harband 8a199e00a2 Merge pull request #1173 from wiserweb/master
[Docs] Specify the lines that will be added by the installation script
2016-07-26 08:30:56 -07:00
wiserweb 6ac7ecf7dc Update README.markdown
Specifies the lines that will be added by the installation script.
2016-07-26 02:31:07 -04:00
Luke Childs a09f225ec7 Update zsh-nvm upgrade command in readme 2016-07-24 21:13:51 +01:00
Jordan Harband e0e1c0379a Merge pull request #1163 from sebthom/patch-1
[Fix] fix "find: warning: Unix filenames usually don't contain slashes" warning

Fixes #871.
2016-07-20 10:30:47 -07:00