Commit Graph

21 Commits (bbe032fa7e219369e2135a3059af6640ab0c4809)

Author SHA1 Message Date
Peter Dave Hello 31bc0a13c2 [Dockerfile] Clean up dated comment 2020-11-03 17:19:03 +08:00
Peter Dave Hello 6110d31969
[dockerfile] Add missing apt pacakge `locales`
locale-gen command seems missing since uncertain point for a while:

```
Step 15/33 : RUN locale-gen en_US.UTF-8
 ---> Running in fae073c89c01
 /bin/bash: locale-gen: command not found
 The command '/bin/bash -o pipefail -c locale-gen en_US.UTF-8' returned
 a non-zero code: 127
```

This patch should fix the Docker image build
2020-09-21 18:20:50 +08:00
Peter Dave Hello 68d2f47c0a
[dockerfile] Update ShellCheck download URL in Dockerfile
see koalaman/shellcheck#1871
2020-09-21 09:36:30 +08:00
Peter Dave Hello 68d331a816
[dockerfile] Remove ShellCheck Segmentation fault workaround
The workaround came from this GitHub issue comment:
https://github.com/koalaman/shellcheck/issues/1053#issuecomment-357816927

Looks like the problem doesn't exist any more:

```
.
.
.
Step 14/33 : RUN shellcheck -V
 ---> Running in 4b7a718c1cbf
ShellCheck - shell script analysis tool
version: 0.7.0
license: GNU General Public License, version 3
website: https://www.shellcheck.net
.
.
.
```

The workaround should be removed so that the Dockerfile will be easier
to be understand and read.
2020-09-21 02:47:57 +08:00
Peter Dave Hello 73438e339e
Update Dockerfile base image to Ubuntu 16.04, cc #2008 2020-03-30 02:17:28 +08:00
Roman Isko 7b0a46eafb
[docker] add libssl-dev to Docker image 2018-06-18 10:33:12 +03:00
Roman Isko dcbecbf2c7
[shellcheck] install shellcheck v0.6.0 in Dockerfile 2018-06-14 10:45:01 +03:00
Peter Dave Hello 4bd99bcfa2 [Dockerfile] Refactor to prevent using `sudo` during build
`sudo` may lead to unpredictable behavior in some cases, and we don't
really need to use `sudo` to reach what we need.
2018-07-12 18:38:15 +08:00
Peter Dave Hello 5f9ccaada0 [Dockerfile] Set the SHELL to bash with pipefail option 2018-07-12 18:38:15 +08:00
Peter Dave Hello 7ff20855a2 [Tests] Integrate dockerfile_lint to test Dockerfile 2018-07-12 18:38:14 +08:00
Peter Dave Hello cdde74a55d [Dockerfile] install missing eclint package 2018-07-12 18:37:40 +08:00
Peter Dave Hello 04b35b5440 [Dockerfile] Use arguments JSON notation for ENTRYPOINT 2018-07-11 15:17:27 +08:00
Peter Dave Hello aacb0b9b97 [Dockerfile] Fix command `From` to be `FROM` 2018-07-11 15:17:27 +08:00
Peter Dave Hello f121e5ace0 [Dockerfile] Add missing quotes for variables 2018-07-11 15:17:18 +08:00
Peter Dave Hello af8038ffec [Dockerfile] Update ShellCheck version to v0.5.0 2018-07-11 15:14:00 +08:00
Peter Dave Hello 265ec90532 [Dockerfile] Add missing name & version LABEL 2018-07-11 15:14:00 +08:00
Peter Dave Hello e2195b4c35 [Dockerfile] Use LABEL instead of deprecated MAINTAINER command 2018-07-11 15:13:57 +08:00
Josh Soref 2859a19bbd
[Docs] fix spelling 2018-03-06 04:38:01 +00:00
Peter Dave Hello 2cd2c0f72e Remove useless trailing newlines 2018-02-26 01:01:30 +08:00
Peter Dave Hello 77da9f5a6d
Optimize ShellCheck installation in Docker image
Use pre-built static release binary instead of building ShellCheck from
the source code, this change would save disk space, time, and much
computing resources.
2018-01-18 00:33:41 +08:00
Peter Dave Hello 3ac49e5ef1
[New] Introduce Docker environment for nvm 2017-04-02 08:03:32 +08:00